[ 
https://issues.apache.org/jira/browse/FLINK-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121486#comment-16121486
 ] 

ASF GitHub Bot commented on FLINK-7381:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4492#discussion_r132427008
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/WebOptions.java ---
    @@ -149,6 +149,13 @@
                        .defaultValue(50)
                        
.withDeprecatedKeys("jobmanager.web.backpressure.delay-between-samples");
     
    +   /**
    +    * Timeout for asynchronous operations by the WebRuntimeMonitor
    +    */
    +   public static final ConfigOption<Long> TIMEOUT = ConfigOptions
    --- End diff --
    
    We should document the time-unit in some way.


> Decouple WebRuntimeMonitor from ActorGateway
> --------------------------------------------
>
>                 Key: FLINK-7381
>                 URL: https://issues.apache.org/jira/browse/FLINK-7381
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Webfrontend
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>
> The {{WebRuntimeMonitor}} has a hard wired dependency on the {{ActorGateway}} 
> in order to communicate with the {{JobManager}}. In order to make it work 
> with the {{JobMaster}} (Flip-6), we have to abstract this dependency away. I 
> propose to add a {{JobManagerGateway}} interface which can be implemented 
> using Akka for the old {{JobManager}} code. The Flip-6 {{JobMasterGateway}} 
> can then directly inherit from this interface.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to