Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4473#discussion_r132373023
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ProducerConfigConstants.java
 ---
    @@ -24,10 +24,28 @@
      */
     public class ProducerConfigConstants extends AWSConfigConstants {
     
    +   /** Deprecated key. **/
    +   public static final String DEPRECATED_COLLECTION_MAX_COUNT = 
"aws.producer.collectionMaxCount";
    +
    +   /** Deprecated key. **/
    +   public static final String DEPRECATED_AGGREGATION_MAX_COUNT = 
"aws.producer.aggregationMaxCount";
    +
        /** Maximum number of items to pack into an PutRecords request. **/
    -   public static final String COLLECTION_MAX_COUNT = 
"aws.producer.collectionMaxCount";
    +   public static final String COLLECTION_MAX_COUNT = "CollectionMaxCount";
    --- End diff --
    
    Do we really want to expose these config keys now?
    AFAIK, if the user wants to tweak these, with this change they should just 
simply refer to the KPL docs to see what keys are available. Explicitly 
exposing partially some keys in Flink but not others is a bit weird, IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to