Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4473#discussion_r132373446
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
 ---
    @@ -165,17 +167,10 @@ public void 
setCustomPartitioner(KinesisPartitioner<OUT> partitioner) {
        public void open(Configuration parameters) throws Exception {
                super.open(parameters);
     
    -           KinesisProducerConfiguration producerConfig = new 
KinesisProducerConfiguration();
    -
    -           
producerConfig.setRegion(configProps.getProperty(ProducerConfigConstants.AWS_REGION));
                
producerConfig.setCredentialsProvider(AWSUtil.getCredentialsProvider(configProps));
    -           if 
(configProps.containsKey(ProducerConfigConstants.COLLECTION_MAX_COUNT)) {
    -                   
producerConfig.setCollectionMaxCount(PropertiesUtil.getLong(configProps,
    -                                   
ProducerConfigConstants.COLLECTION_MAX_COUNT, 
producerConfig.getCollectionMaxCount(), LOG));
    -           }
    -           if 
(configProps.containsKey(ProducerConfigConstants.AGGREGATION_MAX_COUNT)) {
    -                   
producerConfig.setAggregationMaxCount(PropertiesUtil.getLong(configProps,
    -                                   
ProducerConfigConstants.AGGREGATION_MAX_COUNT, 
producerConfig.getAggregationMaxCount(), LOG));
    +           // Override KPL default value if it's not specified by user
    +           if 
(!configProps.containsKey(ProducerConfigConstants.RATE_LIMIT)) {
    +                   
producerConfig.setRateLimit(ProducerConfigConstants.DEFAULT_RATE_LIMIT);
    --- End diff --
    
    Ah I see why now, just read your Javadocs :)
    Should we move this override to 
`KinesisConfigUtil.validateProducerConfiguration`, where the producer config is 
built?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to