[
https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123285#comment-16123285
]
ASF GitHub Bot commented on FLINK-7378:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4485#discussion_r132673916
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
---
@@ -221,13 +228,44 @@ public BufferPool createBufferPool(int
numRequiredBuffers, int maxUsedBuffers) t
}
@Override
+ public BufferPool createFixedBufferPool(int numRequiredBuffers) throws
IOException {
+ synchronized (factoryLock) {
+ if (isDestroyed) {
+ throw new IllegalStateException("Network buffer
pool has already been destroyed.");
+ }
+
+ // Ensure that the number of required buffers can be
satisfied.
+ if (numTotalRequiredBuffers + numRequiredBuffers >
totalNumberOfMemorySegments) {
+ throw new
IOException(String.format("Insufficient number of network buffers: " +
--- End diff --
why not keep the whole message as in `#createBufferPool`?
> Implement the FixedBufferPool for floating buffers of SingleInputGate
> ---------------------------------------------------------------------
>
> Key: FLINK-7378
> URL: https://issues.apache.org/jira/browse/FLINK-7378
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.4.0
>
>
> Currently the number of network buffers in {{LocalBufferPool}} for
> {{SingleInputGate}} is limited by {{a * <number of channels> + b}}, where a
> is the number of exclusive buffers for each channel and b is the number of
> floating buffers shared by all channels.
> Considering the credit-based flow control feature, we want to implement a new
> fixed size buffer pool type used to manage the floating buffers for
> {{SingleInputGate}}.
> Compared with {{LocalBufferPool}}, this is a non-rebalancing buffer pool
> which will not participate in redistributing the left available buffers in
> {{NetworkBufferPool}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
