ASF GitHub Bot commented on FLINK-7378:

Github user zhijiangW commented on the issue:

    @NicoK , Thank you for reviews!
    Considering the difference between `FixedBufferPool` and `LocalBufferPool`, 
I think you are right. I also think of this question when implement this new 
type. Maybe I misunderstood the stephan's meaning from google doc.
    I proposed the new `BufferPoolListener` for interaction easily between 
`RemoteInputChannel` and `BufferPool`, because `RemoteInputChannel` may request 
more floating buffers and wants to be notified more than once, and the boolean 
return can decide the behavior easily. And it can replace the current 
`EventListener` provided in `BufferProvider` interface. In order not to affect 
the current process, I did not replace that in this PR.
    I referred to the existing code format when implementation and found many 
cases keep the space after <p>. Thank you for letting me know the new rule. I 
may modify it next week based on your comments.

> Implement the FixedBufferPool for floating buffers of SingleInputGate
> ---------------------------------------------------------------------
>                 Key: FLINK-7378
>                 URL: https://issues.apache.org/jira/browse/FLINK-7378
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.4.0
> Currently the number of network buffers in {{LocalBufferPool}} for 
> {{SingleInputGate}} is limited by {{a * <number of channels> + b}}, where a 
> is the number of exclusive buffers for each channel and b is the number of 
> floating buffers shared by all channels.
> Considering the credit-based flow control feature, we want to implement a new 
> fixed size buffer pool type used to manage the floating buffers for 
> {{SingleInputGate}}.
> Compared with {{LocalBufferPool}}, this is a non-rebalancing buffer pool 
> which will not participate in redistributing the left available buffers in 
> {{NetworkBufferPool}}.

This message was sent by Atlassian JIRA

Reply via email to