[
https://issues.apache.org/jira/browse/FLINK-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123772#comment-16123772
]
ASF GitHub Bot commented on FLINK-7423:
---------------------------------------
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4525
Hi @XuPingyong thanks for submitting this PR. I'm not clear on why the
`null` check was added in FLINK-4075 and `ContinuousFileProcessingTest` is not
running locally for me. When calling `InputFormat#nextRecord` we can only reuse
the returned object. The object passed to `nextRecord` may be reused internally
by the `InputFormat` so we cannot simply pass in the same object. It would be
better to move `OUT nextElement = serializer.createInstance();` into the outer
loop.
> Always reuse an instance to get elements from the inputFormat
> ---------------------------------------------------------------
>
> Key: FLINK-7423
> URL: https://issues.apache.org/jira/browse/FLINK-7423
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
> Reporter: Xu Pingyong
> Assignee: Xu Pingyong
>
> In InputFormatSourceFunction.java:
> {code:java}
> OUT nextElement = serializer.createInstance();
> while (isRunning) {
> format.open(splitIterator.next());
> // for each element we also check if cancel
> // was called by checking the isRunning flag
> while (isRunning && !format.reachedEnd()) {
> nextElement =
> format.nextRecord(nextElement);
> if (nextElement != null) {
> ctx.collect(nextElement);
> } else {
> break;
> }
> }
> format.close();
> completedSplitsCounter.inc();
> if (isRunning) {
> isRunning = splitIterator.hasNext();
> }
> }
> {code}
> the format may return other element or null when nextRecord, that will may
> cause exception.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
