[ 
https://issues.apache.org/jira/browse/FLINK-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124497#comment-16124497
 ] 

ASF GitHub Bot commented on FLINK-7423:
---------------------------------------

Github user XuPingyong commented on the issue:

    https://github.com/apache/flink/pull/4525
  
    Thanks @greghogan. 
    
          I think  the InputFormat can return anything, may be null or other 
immutable objects that cannot be passed to nextRecord.
         And I am also not clear why the object passed to nextRecord may be 
reused internally by the InputFormat. The param of nextRecord named reuse means 
it may be re-passed to this call again?
    
        What do you think?



> Always reuse an instance  to get elements from the inputFormat 
> ---------------------------------------------------------------
>
>                 Key: FLINK-7423
>                 URL: https://issues.apache.org/jira/browse/FLINK-7423
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>            Reporter: Xu Pingyong
>            Assignee: Xu Pingyong
>
> In InputFormatSourceFunction.java:
> {code:java}
> OUT nextElement = serializer.createInstance();
>                       while (isRunning) {
>                               format.open(splitIterator.next());
>                               // for each element we also check if cancel
>                               // was called by checking the isRunning flag
>                               while (isRunning && !format.reachedEnd()) {
>                                       nextElement = 
> format.nextRecord(nextElement);
>                                       if (nextElement != null) {
>                                               ctx.collect(nextElement);
>                                       } else {
>                                               break;
>                                       }
>                               }
>                               format.close();
>                               completedSplitsCounter.inc();
>                               if (isRunning) {
>                                       isRunning = splitIterator.hasNext();
>                               }
>                       }
> {code}
> the format may return other element or null when nextRecord, that will may 
> cause exception.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to