ASF GitHub Bot commented on FLINK-7337:

GitHub user twalthr opened a pull request:


    [FLINK-7337] [table] Refactor internal handling of time indicator 
attributes and efficiency

    ## What is the purpose of the change
    *This PR is an improvement of @fhueske's PR #4488. For an description see 
#4488. This PR improves the efficiency by not creating objects for every 
timestamps but Long values and serializing them using the LongSerializer. It 
also contains code clean-up changes.*

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-7337

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4532
commit 03ca69505e14aea5452a1b6e77d942ecc2440de4
Author: Fabian Hueske <fhue...@apache.org>
Date:   2017-08-04T00:20:56Z

    [FLINK-7337] [table] Refactor internal handling of time indicator 
    - Expand phyiscal Row schema for time indicators.
    - Refactor computation of logical schema of tables to import.
    - Refactor operators to use time attribute in Row instead of StreamRecord 

commit 876369d41019b3ec5ba824553b31fb2f3b44a18d
Author: Fabian Hueske <fhue...@apache.org>
Date:   2017-08-07T21:39:48Z

    Addressed review feedback

commit 54bfed8debbe29784e0de7f07ebb277df68a4eb5
Author: Fabian Hueske <fhue...@apache.org>
Date:   2017-08-11T14:43:07Z

    minor improvement

commit b0b24011e7c0444e3e1ebaba810edc06e9c85ad6
Author: twalthr <twal...@apache.org>
Date:   2017-08-12T11:51:42Z

    Efficient handling of rowtime timestamps


> Refactor handling of time indicator attributes
> ----------------------------------------------
>                 Key: FLINK-7337
>                 URL: https://issues.apache.org/jira/browse/FLINK-7337
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
> After a [discussion on the dev mailing 
> list|https://lists.apache.org/thread.html/735d55f9022df8ff73566a9f1553e14be94f8443986ad46559b35869@%3Cdev.flink.apache.org%3E]
>  I propose the following changes to the current handling of time indicator 
> attributes:
> * Remove the separation of logical and physical row type.
> ** Hold the event-time timestamp as regular Long field in Row
> ** Represent the processing-time indicator type as a null-valued field in Row 
> (1 bit overhead)
> * Remove materialization of event-time timestamps because timestamp is 
> already accessible in Row.
> * Add {{ProcessFunction}} to set timestamp into the timestamp field of a 
> {{StreamRecord}}.

This message was sent by Atlassian JIRA

Reply via email to