[
https://issues.apache.org/jira/browse/FLINK-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125575#comment-16125575
]
ASF GitHub Bot commented on FLINK-7440:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4537#discussion_r132932684
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -176,6 +177,10 @@ public FlinkKinesisConsumer(List<String> streams,
KinesisDeserializationSchema<T
// check the configuration properties for any conflicting
settings
KinesisConfigUtil.validateConsumerConfiguration(this.configProps);
+ checkArgument(
--- End diff --
How about first checking for null, and then for serializability? (Just seem
more intuitive to me)
> Add eager serializable checks on provided de-/serialization schemas for
> Kinesis consumer / producer
> ---------------------------------------------------------------------------------------------------
>
> Key: FLINK-7440
> URL: https://issues.apache.org/jira/browse/FLINK-7440
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Fix For: 1.4.0, 1.3.3
>
>
> For better user experience, we should add eager serializable checks on the
> provided {{KinesisDeserializationSchema}} / {{KinesisSerializationSchema}},
> with better error messages pointing out exactly that the serialization schema
> isn't serializable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
