[
https://issues.apache.org/jira/browse/FLINK-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125951#comment-16125951
]
ASF GitHub Bot commented on FLINK-7440:
---------------------------------------
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4537#discussion_r132999950
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
---
@@ -1062,4 +1104,28 @@ public boolean isClearCalled() {
return fakeRestoredState;
}
+
+ private final class NonSerializableDeserializationSchema implements
KinesisDeserializationSchema<String> {
--- End diff --
Can you please add a comment explaining why this is not serializable and
why the following one is serializable? Basically pointing out this class is not
static.
> Add eager serializable checks on provided de-/serialization schemas for
> Kinesis consumer / producer
> ---------------------------------------------------------------------------------------------------
>
> Key: FLINK-7440
> URL: https://issues.apache.org/jira/browse/FLINK-7440
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Fix For: 1.4.0, 1.3.3
>
>
> For better user experience, we should add eager serializable checks on the
> provided {{KinesisDeserializationSchema}} / {{KinesisSerializationSchema}},
> with better error messages pointing out exactly that the serialization schema
> isn't serializable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
