[ 
https://issues.apache.org/jira/browse/FLINK-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154076#comment-16154076
 ] 

Chesnay Schepler commented on FLINK-4831:
-----------------------------------------

It's a good question what is missing, let's see. For one we're missing a null 
check when accessing the value of a gauge, and the whole branch should be 
rebased to the latest master. Documentation is also missing. Something to 
investigate would be whether we can ensure that the report is written as one 
big lock, instead of interleaved with other logging messages.

It is true that we can extend AbstractReporter to simplify things.

> Implement a slf4j metric reporter
> ---------------------------------
>
>                 Key: FLINK-4831
>                 URL: https://issues.apache.org/jira/browse/FLINK-4831
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.1.2
>            Reporter: Chesnay Schepler
>            Assignee: Hai Zhou
>            Priority: Minor
>              Labels: easyfix, starter
>
> For debugging purpose it would be very useful to have a log4j metric 
> reporter. If you don't want to setup a metric backend you currently have to 
> rely on JMX, which a) works a bit differently than other reporters (for 
> example it doesn't extend AbstractReporter) and b) makes it a bit tricky to 
> analyze results as metrics are cleaned up once a job finishes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to