Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4358#discussion_r137268826
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobClient.java ---
@@ -415,13 +393,17 @@ private BlobKey putBuffer(@Nullable JobID jobId,
byte[] value, int offset, int l
* the ID of the job the BLOB belongs to (or <tt>null</tt>
if job-unrelated)
* @param inputStream
* the input stream to read the data from
+ * @param permanentBlob
+ * whether the BLOB is permanent (<tt>true</tt>) or
transient (<tt>false</tt>)
*
* @return the computed BLOB key of the uploaded BLOB
*
* @throws IOException
* thrown if an I/O error occurs while uploading the data
to the BLOB server
*/
- private BlobKey putInputStream(@Nullable JobID jobId, InputStream
inputStream) throws IOException {
+ BlobKey putInputStream(@Nullable JobID jobId, InputStream inputStream,
boolean permanentBlob)
--- End diff --
Should we introduce an `enum` instead of a boolean denoting whether the
content is transient or permanent? This would have the advantage that it's much
clearer what's happening when looking at code at the calling side.
---
