Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4358#discussion_r137293376
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/client/JobClient.java ---
@@ -215,10 +215,10 @@ public static ClassLoader retrieveClassLoader(
JobManagerMessages.ClassloadingProps props =
optProps.get();
InetSocketAddress serverAddress = new
InetSocketAddress(jobManager.getHostname(), props.blobManagerPort());
- final BlobCache blobClient;
+ final PermanentBlobCache blobClient;
try {
- // TODO: Fix lifecycle of BlobCache to properly
close it upon usage
- blobClient = new BlobCache(serverAddress,
config, highAvailabilityServices.createBlobStore());
+ // TODO: Fix lifecycle of PermanentBlobCache to
properly close it upon usage
+ blobClient = new
PermanentBlobCache(serverAddress, config,
highAvailabilityServices.createBlobStore());
--- End diff --
shouldn't the variable be called `permanentBlobCache` instead of
`blobClient`?
---
