[
https://issues.apache.org/jira/browse/FLINK-7567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156986#comment-16156986
]
ASF GitHub Bot commented on FLINK-7567:
---------------------------------------
GitHub user mlipkovich opened a pull request:
https://github.com/apache/flink/pull/4655
[FLINK-7567]: Removed keepPartitioning parameter from iterate method
## What is the purpose of the change
Removed parameter keepPartitioning from DataStream#iterate method since
it's ignored. Also slightly modified error message related to different
parallelism levels of input and feedback streams
## Brief change log
- Removed parameter keepPartitioning from DataStream#iterate
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / no) yes
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no /
don't know) no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know) no
## Documentation
- Does this pull request introduce a new feature? (yes / no) no
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / not documented) not applicable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mlipkovich/flink FLINK-7567
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4655.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4655
----
commit 2525aef6f65d297142472ae6532e3bddb08df0fd
Author: Mikhail Lipkovich <[email protected]>
Date: 2017-09-07T14:05:22Z
[FLINK-7567]: Removed keepPartitioning parameter from iterate method
----
> DataStream#iterate() on env.fromElements() / env.fromCollection() does not
> work
> -------------------------------------------------------------------------------
>
> Key: FLINK-7567
> URL: https://issues.apache.org/jira/browse/FLINK-7567
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
> Affects Versions: 1.3.2
> Environment: OS X 10.12.6, Oracle JDK 1.8.0_144, Flink 1.3.2
> Reporter: Peter Ertl
> Assignee: Mikhail Lipkovich
>
> When I try to execute this simple snippet of code
> {code}
> @Test
> def iterateOnElements(): Unit = {
> val env = StreamExecutionEnvironment.getExecutionEnvironment
> // do something silly just do get iteration going ...
> val result = env.fromElements(1, 2, 3).iterate(it => {
> (it.filter(_ > 0).map(_ - 1), it.filter(_ > 0).map(_ => 'x'))
> })
> result.print()
> env.execute()
> }
> {code}
> I get the following exception:
> {code}
> java.lang.UnsupportedOperationException: Parallelism of the feedback stream
> must match the parallelism of the original stream. Parallelism of original
> stream: 1; parallelism of feedback stream: 8
> at
> org.apache.flink.streaming.api.transformations.FeedbackTransformation.addFeedbackEdge(FeedbackTransformation.java:87)
> at
> org.apache.flink.streaming.api.datastream.IterativeStream.closeWith(IterativeStream.java:77)
> at
> org.apache.flink.streaming.api.scala.DataStream.iterate(DataStream.scala:519)
> at atp.analytics.CassandraReadTest.iterate2(CassandraReadTest.scala:134)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> at
> com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
> at
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
> at
> com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> {code}
> Since is just the simplest iterating stream setup I could imagine this error
> makes no sense to me :-P
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
