[
https://issues.apache.org/jira/browse/FLINK-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166017#comment-16166017
]
ASF GitHub Bot commented on FLINK-7619:
---------------------------------------
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/4671
[FLINK-7619] Improve abstraction in AbstractAsyncIOCallable to better fit
## What is the purpose of the change
This PR improves the abstractions around resource management for async
backend snapshots.
## Brief change log
- return value when removing streams from {{CloseableRegistry}} to not rely
in idempotent close, but enforce close to be called exactly once.
- Introduces {{AbstractAsyncCallableWithResources}} as a more general
abstraction to manage resources in async checkpointing.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink
improve-snapshot-resourcemngmt
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4671.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4671
----
----
> Improve abstraction in AbstractAsyncIOCallable to better fit
> ------------------------------------------------------------
>
> Key: FLINK-7619
> URL: https://issues.apache.org/jira/browse/FLINK-7619
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Minor
>
> The abstraction of AbstractAsyncIOCallable does not fit to well with todays
> needs in checkpointing backends. Originally, backends were assumed to only
> open one stream that is managed by the abstraction. In fact, concrete
> implementations always extended that in practise. We can redo this in a way
> that more resources can be managed by the abstraction.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
