[
https://issues.apache.org/jira/browse/FLINK-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176245#comment-16176245
]
ASF GitHub Bot commented on FLINK-7619:
---------------------------------------
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4671#discussion_r140456968
--- Diff:
flink-core/src/main/java/org/apache/flink/util/AbstractCloseableRegistry.java
---
@@ -90,14 +90,14 @@ public final void registerClosable(C closeable) throws
IOException {
*
* @param closeable instance to remove from the registry.
*/
- public final void unregisterClosable(C closeable) {
+ public final boolean unregisterCloseable(C closeable) {
--- End diff --
Please add a description of the return parameter. Doesn't need to be a
`@param` block, a description in the text is enough. Same for the method below.
> Improve abstraction in AbstractAsyncIOCallable to better fit
> ------------------------------------------------------------
>
> Key: FLINK-7619
> URL: https://issues.apache.org/jira/browse/FLINK-7619
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Reporter: Stefan Richter
> Assignee: Stefan Richter
> Priority: Minor
>
> The abstraction of AbstractAsyncIOCallable does not fit to well with todays
> needs in checkpointing backends. Originally, backends were assumed to only
> open one stream that is managed by the abstraction. In fact, concrete
> implementations always extended that in practise. We can redo this in a way
> that more resources can be managed by the abstraction.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
