Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r138905728
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java
---
@@ -218,7 +221,7 @@ public long addRecord(T record) throws IOException {
return offset;
}
- public MutableObjectIterator<T>
finishWriteAndSortKeys(List<MemorySegment> memory) throws IOException {
+ public MutableObjectIterator<T>
finishWriteAndSortKeys(List<MemorySegment> memory) throws IOException,
IllegalAccessException, TemplateException, InstantiationException,
CompileException, InvocationTargetException, NoSuchMethodException,
ClassNotFoundException {
--- End diff --
Or, maybe even better to catch all of these in the sorter factory method
(`SorterFactory.createSorter`), and create a non-codegen sorter when any of
these exceptions happen (and log a warning).
---
