Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r139920526
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java
---
@@ -309,7 +309,7 @@ public boolean write(T record) throws IOException {
// Access Utilities
//
------------------------------------------------------------------------
- private long readPointer(int logicalPosition) {
+ protected long readPointer(int logicalPosition) {
--- End diff --
Changing a method from `private` to `protected` affects how it can be
inlined. See for example this blog post:
http://normanmaurer.me/blog/2014/05/15/Inline-all-the-Things (the difference of
`private` and `public` is discussed at the end of the post).
If it is just about making them accessible (and not overriding them) in the
code-gen'd sorter, declaring them `final` might solve the issue. @StephanEwen
and @pnowojski might have some additional advice here.
---
