Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4499#discussion_r136027041
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java
---
@@ -281,6 +284,67 @@ public void testProducerFailedException() throws
Exception {
ch.getNextBuffer();
}
+ @Test
+ public void testNotifyCreditOnBufferRecycling() throws Exception {
+ // Setup
+ final SingleInputGate inputGate = mock(SingleInputGate.class);
+ final PartitionRequestClient client =
mock(PartitionRequestClient.class);
+ final RemoteInputChannel inputChannel =
createRemoteInputChannel(inputGate, client, new Tuple2<>(0, 0));
+
+ inputChannel.requestSubpartition(0);
+
+ // Recycle exclusive segment
+
inputChannel.recycle(HeapMemorySegment.FACTORY.allocateUnpooledSegment(1024,
inputChannel));
--- End diff --
why not use the more generic `MemorySegmentFactory.getFactory()`?
---
