Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4499#discussion_r138922984
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -183,18 +214,40 @@ void notifySubpartitionConsumed() {
}
/**
- * Releases all received buffers and closes the partition request
client.
+ * Releases all received and available buffers, closes the partition
request client.
*/
@Override
void releaseAllResources() throws IOException {
if (isReleased.compareAndSet(false, true)) {
+
+ final List<MemorySegment> recyclingSegments = new
ArrayList<>();
+
synchronized (receivedBuffers) {
Buffer buffer;
while ((buffer = receivedBuffers.poll()) !=
null) {
- buffer.recycle();
+ if (buffer.getRecycler() == this) {
+
recyclingSegments.add(buffer.getMemorySegment());
--- End diff --
Although this is probably more performant than calling `recycle()`, the
beauty of having `this` as the recycler for our exclusive buffers actually
allows very simple and nice code only calling `recycle()` in all cases. Since
we're not on the hot path here, I'd actually prefer that, or what do you think?
---
