Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4625#discussion_r139399103
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamWindowJoin.scala
---
@@ -166,16 +185,16 @@ class DataStreamWindowJoin(
def createProcTimeInnerJoinFunction(
leftDataStream: DataStream[CRow],
rightDataStream: DataStream[CRow],
+ returnTypeInfo: TypeInformation[CRow],
joinFunctionName: String,
joinFunctionCode: String,
leftKeys: Array[Int],
rightKeys: Array[Int]): DataStream[CRow] = {
- val returnTypeInfo = CRowTypeInfo(schema.typeInfo)
-
- val procInnerJoinFunc = new ProcTimeWindowInnerJoin(
--- End diff --
We should remove the previous implementation if we don't use it anymore.
---