Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4499#discussion_r139590215
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -100,7 +122,16 @@ public RemoteInputChannel(
}
void assignExclusiveSegments(List<MemorySegment> segments) {
--- End diff --
Yes, this method should be called only once after `RemoteInputChannel`
created. I think `assignExclusiveSegments` can describe the semantics of
invoking only once, and `addExclusiveSegments` seems allow to be called
multiple times.
I currently take the third way you suggested, adding the `checkState` to
avoid multi calling.
---
