[
https://issues.apache.org/jira/browse/FLINK-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171616#comment-16171616
]
ASF GitHub Bot commented on FLINK-7528:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4598#discussion_r139678620
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/HandlerRedirectUtilsTest.java
---
@@ -39,40 +39,36 @@
*/
public class HandlerRedirectUtilsTest extends TestLogger {
- private static final String localJobManagerAddress =
"akka.tcp://[email protected]:1234/user/foobar";
- private static final String remoteHostname = "127.0.0.2";
- private static final int webPort = 1235;
- private static final String remoteURL = remoteHostname + ':' + webPort;
- private static final String remotePath = "akka.tcp://flink@" +
remoteURL + "/user/jobmanager";
+ private static final String localRestAddress = "http://127.0.0.1:1234";;
+ private static final String remoteRestAddress = "http://127.0.0.2:1234";;
@Test
- public void testGetRedirectAddressWithLocalAkkaPath() throws Exception {
+ public void testGetRedirectAddressWithLocalEqualsRemoteRESTAddress()
throws Exception {
JobManagerGateway jobManagerGateway =
mock(JobManagerGateway.class);
-
when(jobManagerGateway.getAddress()).thenReturn("akka://flink/user/foobar");
+
when(jobManagerGateway.requestRestAddress(any(Time.class))).thenReturn(CompletableFuture.completedFuture(localRestAddress));
- Optional<CompletableFuture<String>> redirectingAddress =
HandlerRedirectUtils.getRedirectAddress(
- localJobManagerAddress,
+ CompletableFuture<Optional<String>> redirectingAddressFuture =
HandlerRedirectUtils.getRedirectAddress(
--- End diff --
Not strictly, but neither did it fit perfectly into another PR. Given all
this rebasing hassle, I would like to simply keep it here.
> Create Dispatcher REST endpoint
> -------------------------------
>
> Key: FLINK-7528
> URL: https://issues.apache.org/jira/browse/FLINK-7528
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination, REST
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: flip-6
>
> Create and integrate the {{DispatcherRestEndpoint}} with the {{Dispatcher}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
