[ 
https://issues.apache.org/jira/browse/FLINK-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171619#comment-16171619
 ] 

ASF GitHub Bot commented on FLINK-7528:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4598#discussion_r139679505
  
    --- Diff: 
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNSessionCapacitySchedulerITCase.java
 ---
    @@ -153,68 +153,62 @@ public void testTaskManagerFailure() {
     
                // ------------------------ Test if JobManager web interface is 
accessible -------
     
    -           YarnClient yc = null;
    -           try {
    -                   yc = YarnClient.createYarnClient();
    -                   yc.init(YARN_CONFIGURATION);
    -                   yc.start();
    +           final YarnClient yc = YarnClient.createYarnClient();
    +           yc.init(YARN_CONFIGURATION);
    +           yc.start();
     
    -                   List<ApplicationReport> apps = 
yc.getApplications(EnumSet.of(YarnApplicationState.RUNNING));
    --- End diff --
    
    True, but I came across while testing the Dispatcher REST endpoint in the 
YARN case. I think there is some value in letting the test fail with the proper 
stack trace instead of only failing the test with the failure message.


> Create Dispatcher REST endpoint
> -------------------------------
>
>                 Key: FLINK-7528
>                 URL: https://issues.apache.org/jira/browse/FLINK-7528
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, REST
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> Create and integrate the {{DispatcherRestEndpoint}} with the {{Dispatcher}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to