Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4603#discussion_r139898963
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/ClusterOverviewHeaders.java
 ---
    @@ -0,0 +1,60 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.messages;
    +
    +import 
org.apache.flink.runtime.messages.webmonitor.StatusOverviewWithVersion;
    +import org.apache.flink.runtime.rest.HttpMethodWrapper;
    +import org.apache.flink.runtime.rest.handler.legacy.ClusterOverviewHandler;
    +
    +import 
org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus;
    +
    +/**
    + * Message headers for the {@link ClusterOverviewHandler}.
    + */
    +public class ClusterOverviewHeaders implements 
MessageHeaders<EmptyRequestBody, StatusOverviewWithVersion, 
EmptyMessageParameters> {
    +   @Override
    +   public Class<EmptyRequestBody> getRequestClass() {
    +           return EmptyRequestBody.class;
    +   }
    +
    +   @Override
    +   public HttpMethodWrapper getHttpMethod() {
    +           return HttpMethodWrapper.GET;
    +   }
    +
    +   @Override
    +   public String getTargetRestEndpointURL() {
    +           return "/overview";
    --- End diff --
    
    Maybe we should make `ClusterOverviewHandler#CLUSTER_OVERVIEW_REST_PATH` 
public and reuse that


---

Reply via email to