Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3511#discussion_r140258895
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java
 ---
    @@ -309,7 +309,7 @@ public boolean write(T record) throws IOException {
        //                           Access Utilities
        // 
------------------------------------------------------------------------
        
    -   private long readPointer(int logicalPosition) {
    +   protected long readPointer(int logicalPosition) {
    --- End diff --
    
    `protected final` with a comment why is it so should be ok.


---

Reply via email to