Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/4688#discussion_r140281116
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/CurrentJobsOverviewHandler.java
---
@@ -92,24 +101,26 @@ public CurrentJobsOverviewHandler(
StringWriter writer = new
StringWriter();
try {
JsonGenerator gen =
JsonFactory.JACKSON_FACTORY.createGenerator(writer);
+ final
JobDetails.JobDetailsSerializer jobDetailsSerializer = new
JobDetails.JobDetailsSerializer();
+
gen.writeStartObject();
if (includeRunningJobs &&
includeFinishedJobs) {
gen.writeArrayFieldStart("running");
- for (JobDetails detail
: result.getRunningJobs()) {
-
writeJobDetailOverviewAsJson(detail, gen, now);
+ for (JobDetails detail
: result.getRunning()) {
+
jobDetailsSerializer.serialize(detail, gen, null);
}
gen.writeEndArray();
gen.writeArrayFieldStart("finished");
--- End diff --
"finished" --> can use `MultipleJobsDetails.FIELD_NAME_JOBS_FINISHED`
---
