[GitHub] flink pull request #4688: [FLINK-7638] [flip6] Port CurrentJobsOverviewHandl...

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4688#discussion_r140291439
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/CurrentJobsOverviewHandler.java
 ---
    @@ -92,24 +101,26 @@ public CurrentJobsOverviewHandler(
                                        StringWriter writer = new 
StringWriter();
                                        try {
                                                JsonGenerator gen = 
JsonFactory.JACKSON_FACTORY.createGenerator(writer);
    +                                           final 
JobDetails.JobDetailsSerializer jobDetailsSerializer = new 
JobDetails.JobDetailsSerializer();
    +
                                                gen.writeStartObject();
     
                                                if (includeRunningJobs && 
includeFinishedJobs) {
                                                        
gen.writeArrayFieldStart("running");
    --- End diff --
    
    True, will change it.


---