[ 
https://issues.apache.org/jira/browse/FLINK-7446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179065#comment-16179065
 ] 

ASF GitHub Bot commented on FLINK-7446:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4710#discussion_r140778116
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/definedTimeAttributes.scala
 ---
    @@ -30,10 +30,16 @@ package org.apache.flink.table.sources
     trait DefinedRowtimeAttribute {
     
       /**
    -    * Defines a name of the event-time attribute that represents Flink's
    -    * event-time. Null if no rowtime should be available.
    +    * Defines a name of the event-time attribute that represents Flink's 
event-time, i.e., an
    +    * attribute that is aligned with the watermarks of the table.
    --- End diff --
    
    `that is aligned with the watermarks of the underlying DataStream`?


> Support to define an existing field as the rowtime field for TableSource
> ------------------------------------------------------------------------
>
>                 Key: FLINK-7446
>                 URL: https://issues.apache.org/jira/browse/FLINK-7446
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Jark Wu
>            Assignee: Fabian Hueske
>
> Currently {{DefinedRowtimeAttribute}} can define an appended rowtime field 
> for a {{TableSource}}. But it would be helpful if we can support to define an 
> existing field as the rowtime field. Just like registering a DataStream, the 
> rowtime field can be appended but also can replace an existing field.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to