[ 
https://issues.apache.org/jira/browse/FLINK-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180368#comment-16180368
 ] 

ASF GitHub Bot commented on FLINK-7690:
---------------------------------------

GitHub user suez1224 opened a pull request:

    https://github.com/apache/flink/pull/4724

    [FLINK-7690] [Cluster Management] Do not call actorSystem.awaitTermination 
from akka's main message han…

    ## What is the purpose of the change
    
    *During shutdown, do not wait for the ActorSystem's termination within the 
main akka message handling thread as it will block the job from terminating 
forever.*
    
    
    ## Brief change log
    
    *(for example:)*
      - *call ActorSystem.awaitTermination from a different thread.*
    
    
    ## Verifying this change
    
      - *Manually verified the change by running the example streaming 
WordCount job on local YARN cluster.*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: yes
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented?  N/A
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/suez1224/flink fix-jobmaster-await-termination

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4724
    
----
commit 291313719ac2ae185dab42a572eb5e4d0e34e7dd
Author: Shuyi Chen <[email protected]>
Date:   2017-09-26T06:25:49Z

    Do not call actorSystem.awaitTermination from akka's main message handling 
thread

----


> Do not call actorSystem.awaitTermination from the main akka message handling 
> thread
> -----------------------------------------------------------------------------------
>
>                 Key: FLINK-7690
>                 URL: https://issues.apache.org/jira/browse/FLINK-7690
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Shuyi Chen
>            Assignee: Shuyi Chen
>              Labels: flip-6
>
> In flip-6, this bug causes the yarn job to hang forever with RUNNING status 
> when the enclosing flink job has already failed/finished.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to