[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

[twalthr]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4536#discussion_r140986388
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkTableFunctionImpl.scala
 ---
    @@ -36,10 +36,8 @@ import org.apache.flink.table.calcite.FlinkTypeFactory
     class FlinkTableFunctionImpl[T](
         val typeInfo: TypeInformation[T],
         val fieldIndexes: Array[Int],
    -    val fieldNames: Array[String],
    -    val evalMethod: Method)
    -  extends ReflectiveFunctionBase(evalMethod)
    --- End diff --
    
    I think we don't need `ReflectiveFunctionBase` anymore. The logic is 
implemented by us now.


---