[
https://issues.apache.org/jira/browse/FLINK-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181145#comment-16181145
]
ASF GitHub Bot commented on FLINK-7663:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4699#discussion_r141119740
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestEndpointITCase.java
---
@@ -162,8 +225,8 @@ public void testEndpoints() throws Exception {
@Override
protected CompletableFuture<TestResponse>
handleRequest(@Nonnull HandlerRequest<TestRequest, TestParameters> request,
RestfulGateway gateway) throws RestHandlerException {
-
Assert.assertEquals(request.getPathParameter(JobIDPathParameter.class),
PATH_JOB_ID);
-
Assert.assertEquals(request.getQueryParameter(JobIDQueryParameter.class).get(0),
QUERY_JOB_ID);
+
assertEquals(request.getPathParameter(JobIDPathParameter.class), PATH_JOB_ID);
--- End diff --
How about we stick to the import pattern that already exists in a given
file instead of switching back and forth?
> Allow AbstractRestHandler to handle bad requests
> ------------------------------------------------
>
> Key: FLINK-7663
> URL: https://issues.apache.org/jira/browse/FLINK-7663
> Project: Flink
> Issue Type: Bug
> Components: REST
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> The {{AbstractRestHandler}} parses the request and tries to generate a
> {{HandlerRequest}}. If this fails, then the server answers with an internal
> server error. Instead we should allow the {{AbstractRestHandler}} to be able
> to return a BAD_REQUEST status code. In order to do that, I would like to
> introduce a {{HandlerRequestException}} which can be thrown while creating
> the {{HandlerRequest}}. If this exception is thrown, then we return an error
> message with {{BAD_REQUEST}} {{HttpResponseStatus}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
