[
https://issues.apache.org/jira/browse/FLINK-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182414#comment-16182414
]
ASF GitHub Bot commented on FLINK-7663:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4699#discussion_r141317701
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestEndpointITCase.java
---
@@ -237,8 +300,8 @@ public TestParameters getUnresolvedMessageParameters() {
}
private static class TestParameters extends MessageParameters {
- private final JobIDPathParameter jobIDPathParameter = new
JobIDPathParameter();
- private final JobIDQueryParameter jobIDQueryParameter = new
JobIDQueryParameter();
+ protected final JobIDPathParameter jobIDPathParameter = new
JobIDPathParameter();
--- End diff --
To make it accessible when you have a `FaultyTestParameter` instance. Can
also cast it which gives access to `jobIDPathParameter`.
> Allow AbstractRestHandler to handle bad requests
> ------------------------------------------------
>
> Key: FLINK-7663
> URL: https://issues.apache.org/jira/browse/FLINK-7663
> Project: Flink
> Issue Type: Bug
> Components: REST
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
>
> The {{AbstractRestHandler}} parses the request and tries to generate a
> {{HandlerRequest}}. If this fails, then the server answers with an internal
> server error. Instead we should allow the {{AbstractRestHandler}} to be able
> to return a BAD_REQUEST status code. In order to do that, I would like to
> introduce a {{HandlerRequestException}} which can be thrown while creating
> the {{HandlerRequest}}. If this exception is thrown, then we return an error
> message with {{BAD_REQUEST}} {{HttpResponseStatus}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
