[
https://issues.apache.org/jira/browse/FLINK-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183940#comment-16183940
]
ASF GitHub Bot commented on FLINK-7652:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4734#discussion_r141575013
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/CurrentJobIdsHandler.java
---
@@ -68,36 +84,9 @@ public CurrentJobIdsHandler(Executor executor, Time
timeout) {
StringWriter writer = new
StringWriter();
JsonGenerator gen =
JsonFactory.JACKSON_FACTORY.createGenerator(writer);
-
- gen.writeStartObject();
-
-
gen.writeArrayFieldStart("jobs-running");
- for (JobID jid :
overview.getJobsRunningOrPending()) {
-
gen.writeString(jid.toString());
- }
- gen.writeEndArray();
-
-
gen.writeArrayFieldStart("jobs-finished");
- for (JobID jid :
overview.getJobsFinished()) {
-
gen.writeString(jid.toString());
- }
- gen.writeEndArray();
-
-
gen.writeArrayFieldStart("jobs-cancelled");
- for (JobID jid :
overview.getJobsCancelled()) {
-
gen.writeString(jid.toString());
- }
- gen.writeEndArray();
-
-
gen.writeArrayFieldStart("jobs-failed");
- for (JobID jid :
overview.getJobsFailed()) {
-
gen.writeString(jid.toString());
- }
- gen.writeEndArray();
-
- gen.writeEndObject();
-
+ new
JobsWithIDsOverview.JobsWithIDsOverviewSerializer().serialize(overview, gen,
null);
--- End diff --
we could store the serializer in a field.
> Port CurrentJobIdsHandler to new REST endpoint
> ----------------------------------------------
>
> Key: FLINK-7652
> URL: https://issues.apache.org/jira/browse/FLINK-7652
> Project: Flink
> Issue Type: Sub-task
> Components: REST, Webfrontend
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Labels: flip-6
> Fix For: 1.4.0
>
>
> Port existing {{CurrentJobIdsHandler}} to new REST endpoint
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
