Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4358#discussion_r142133777
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
    @@ -375,7 +378,32 @@ public File getFile(BlobKey key) throws IOException {
         *              Thrown if the file retrieval failed.
         */
        @Override
    -   public File getFile(JobID jobId, BlobKey key) throws IOException {
    +   public File getTransientFile(JobID jobId, BlobKey key) throws 
IOException {
    +           checkNotNull(jobId);
    +           return getFileInternal(jobId, key);
    +   }
    +
    +   /**
    +    * Returns the path to a local copy of the file associated with the 
provided job ID and blob
    +    * key.
    +    * <p>
    +    * We will first attempt to serve the BLOB from the local storage. If 
the BLOB is not in
    +    * there, we will try to download it from the HA store.
    +    *
    +    * @param jobId
    +    *              ID of the job this blob belongs to
    +    * @param key
    +    *              blob key associated with the requested file
    +    *
    +    * @return The path to the file.
    +    *
    +    * @throws java.io.FileNotFoundException
    +    *              if the BLOB does not exist;
    +    * @throws IOException
    +    *              if any other error occurs when retrieving the file
    +    */
    +   @Override
    +   public File getPermanentFile(JobID jobId, BlobKey key) throws 
IOException {
    --- End diff --
    
    Same here for `BlobType.PERMANENT`


---

Reply via email to