Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4358#discussion_r142134172
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
    @@ -375,7 +378,32 @@ public File getFile(BlobKey key) throws IOException {
         *              Thrown if the file retrieval failed.
         */
        @Override
    -   public File getFile(JobID jobId, BlobKey key) throws IOException {
    +   public File getTransientFile(JobID jobId, BlobKey key) throws 
IOException {
    +           checkNotNull(jobId);
    --- End diff --
    
    What about making the usage of blob keys failsafe by having different types 
of `BlobKey`. E.g. `TransientBlobKey` and `PermanentBlobKey`?


---

Reply via email to