[
https://issues.apache.org/jira/browse/FLINK-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200240#comment-16200240
]
ASF GitHub Bot commented on FLINK-7791:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/4802
[FLINK-7791] [REST][client] Integrate LIST command into RestClusterClient
## What is the purpose of the change
This PR integrates the LIST command into the RestClusterClient. This is a
fully working implementation and leverages the CurrentJobsOverviewHeaders.
## Brief change log
* move LIST logic from CliFrontend into ClusterClient
* separate CliFrontendListCancelTest into distinct test cases for list &
cancel
* implement LIST logic for RestClusterClient, based on the
CurrentJobsOverviewHeaders
## Verifying this change
This change added tests and can be verified as follows:
* the changes to the CliFrontend are covered by modified tests in
CliFrontendListTest
* the changes to the ClusterClient are covered by new tests in
ClusterClientTest
* the changes to the RestClusterClient are covered by
RestClusterClientTest#testListJobs
For manual verification:
* start a flip6 cluster with `start-cluster.sh flip6`
* submit a long-running job with `flink run -flip <jar>`
* execute the list command with `flink list -flip6`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 7791
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4802.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4802
----
commit 4463158258aff8f63c47b96dd4d3f10e20c1987f
Author: zentol <[email protected]>
Date: 2017-10-11T11:43:40Z
[FLINK-7807] [REST] Log exceptions in HandlerUtils methods
commit cc80c685aab4daf3aa7a0fd320e99627cbba8b8c
Author: zentol <[email protected]>
Date: 2017-10-11T11:47:38Z
[FLINK-7808] [REST] JobDetails constructor checks size of tasksPerState
argument
commit 274c3436c7d5566ad16d422b28a3e491ac58096b
Author: zentol <[email protected]>
Date: 2017-10-10T14:52:10Z
[FLINK-7791] [Client] Move LIST logic into ClusterClient
commit eb6beff15f37edd8efd68791526a930e44c1f007
Author: zentol <[email protected]>
Date: 2017-10-11T11:58:59Z
[FLINK-7791] [REST][client] Integrate LIST command into RestClusterClient
----
> Integrate LIST command into REST client
> ---------------------------------------
>
> Key: FLINK-7791
> URL: https://issues.apache.org/jira/browse/FLINK-7791
> Project: Flink
> Issue Type: Sub-task
> Components: Client, REST
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
