[ 
https://issues.apache.org/jira/browse/FLINK-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16200258#comment-16200258
 ] 

ASF GitHub Bot commented on FLINK-7791:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4802#discussion_r144006709
  
    --- Diff: 
flink-clients/src/test/java/org/apache/flink/client/program/ClusterClientTest.java
 ---
    @@ -134,6 +140,25 @@ public void testClusterClientSavepoint() throws 
Exception {
                }
        }
     
    +   @Test
    +   public void testClusterClientList() throws Exception {
    +           Configuration config = new Configuration();
    +           config.setString(JobManagerOptions.ADDRESS, "localhost");
    +
    +           TestListActorGateway gateway = new TestListActorGateway();
    +           ClusterClient clusterClient = new TestClusterClient(config, 
gateway);
    +           try {
    +                   CompletableFuture<Collection<JobDetails>> 
jobDetailsFuture = clusterClient.listJobs();
    +                   Collection<JobDetails> jobDetails = 
jobDetailsFuture.get();
    +                   Assert.assertTrue(gateway.messageArrived);
    +                   // finished jobs should be ignored
    +                   Assert.assertEquals(1, jobDetails.size());
    --- End diff --
    
    Shouldn't we also retrieve the finished jobs here?


> Integrate LIST command into REST client
> ---------------------------------------
>
>                 Key: FLINK-7791
>                 URL: https://issues.apache.org/jira/browse/FLINK-7791
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client, REST
>    Affects Versions: 1.4.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to