[ 
https://issues.apache.org/jira/browse/FLINK-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203017#comment-16203017
 ] 

ASF GitHub Bot commented on FLINK-7764:
---------------------------------------

GitHub user xccui opened a pull request:

    https://github.com/apache/flink/pull/4819

    [FLINK-7764] [kafka] Fix the operator setting problem of 
FlinkKafkaProducer010(1.3)

    ## What is the purpose of the change
    
    This PR fixes the operator setting (name, uid, parallelism, etc.) problem 
of FlinkKafkaProducer010 for `release-1.3` branch.
    
    
    ## Brief change log
    
      - Override all the DataStreamSink public methods in 
FlinkKafkaProducer010.FlinkKafkaProducer010Configuration
      - Fix the typo names "FlinKafkaProducer" ==> "FlinkKafkaProducer".
    
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xccui/flink FLINK-7764-1.3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4819.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4819
    
----
commit d2fd6cc1c7b074f7810c7034a4a87e8d8a1fe074
Author: Xingcan Cui <[email protected]>
Date:   2017-10-11T15:42:29Z

    [FLINK-7764] [kafka] Enable the operator settings for FlinkKafkaProducer010
    
    [hotfix] [kafka] Fix the config parameter names in KafkaTestBase.

----


> FlinkKafkaProducer010 does not accept name, uid, or parallelism
> ---------------------------------------------------------------
>
>                 Key: FLINK-7764
>                 URL: https://issues.apache.org/jira/browse/FLINK-7764
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector
>    Affects Versions: 1.4.0, 1.3.2
>            Reporter: Fabian Hueske
>            Assignee: Xingcan Cui
>
> As [reported on the user 
> list|https://lists.apache.org/thread.html/1e97b79cb5611a942beb609a61b5fba6d62a49c9c86336718a9a0004@%3Cuser.flink.apache.org%3E]:
> When I try to use KafkaProducer with timestamps it fails to set name, uid or 
> parallelism. It uses default values.
> {code}
> FlinkKafkaProducer010.FlinkKafkaProducer010Configuration<T> producer = 
> FlinkKafkaProducer010
>     .writeToKafkaWithTimestamps(stream, topicName, schema, props, 
> partitioner);
> producer.setFlushOnCheckpoint(flushOnCheckpoint);
> producer.name("foo")
>         .uid("bar")
>         .setParallelism(5);
> return producer;
> {code}
> As operator name it shows "FlinKafkaProducer 0.10.x” with the typo.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to