[
https://issues.apache.org/jira/browse/FLINK-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203354#comment-16203354
]
ASF GitHub Bot commented on FLINK-7812:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4801
Thanks for this addition. Few comments:
- Please try to follow the common (though not enforced) code style when
it comes to empty lines between class declarations, fields, methods, etc.
- What is the license of the new dependency? Can you send a link so we
can verify that?
- If possible, let's shade that dependency, avoid increasing the
dependency footprint.
- Can we harmonize the config keys between the memory logger and the new
system metrics?
> Log system resources as metrics
> -------------------------------
>
> Key: FLINK-7812
> URL: https://issues.apache.org/jira/browse/FLINK-7812
> Project: Flink
> Issue Type: New Feature
> Components: Metrics
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Fix For: 1.4.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
