[jira] [Commented] (FLINK-7798) Add support for windowed joins to Table API

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-7798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204515#comment-16204515
 ] 

ASF GitHub Bot commented on FLINK-7798:
---------------------------------------

Github user xccui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4825#discussion_r144688279
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/JoinITCase.scala
 ---
    @@ -0,0 +1,114 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.runtime.stream.table
    +
    +import org.apache.flink.api.scala._
    +import org.apache.flink.streaming.api.TimeCharacteristic
    +import org.apache.flink.table.api.scala._
    +import org.apache.flink.streaming.api.scala.{DataStream, 
StreamExecutionEnvironment}
    +import org.apache.flink.streaming.util.StreamingMultipleProgramsTestBase
    +import org.apache.flink.table.api.{TableEnvironment, TableException}
    +import org.apache.flink.table.runtime.utils.StreamITCase
    +import org.apache.flink.types.Row
    +import org.junit.Test
    +
    +/**
    +  * Test if the table joins can be correctly translated.
    +  */
    +class JoinITCase extends StreamingMultipleProgramsTestBase {
    --- End diff --
    
    Thanks for pointing this out, @fhueske. I'll rework the test.


> Add support for windowed joins to Table API
> -------------------------------------------
>
>                 Key: FLINK-7798
>                 URL: https://issues.apache.org/jira/browse/FLINK-7798
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Xingcan Cui
>            Priority: Blocker
>             Fix For: 1.4.0
>
>
> Currently, windowed joins on streaming tables are only supported through SQL.
> The Table API should support these joins as well. For that, we have to adjust 
> the Table API validation and translate the API into the respective logical 
> plan. Since most of the code should already be there for the batch Table API 
> joins, this should be fairly straightforward.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)