Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4586#discussion_r144807511
  
    --- Diff: 
flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTest.java
 ---
    @@ -124,19 +133,6 @@ public void histogramIsReportedAsPrometheusSummary() 
throws UnirestException {
        }
     
        @Test
    -   public void meterRateIsReportedAsPrometheusGauge() throws 
UnirestException {
    -           Meter testMeter = new TestMeter();
    -
    -           String meterName = "testMeter";
    -           String counterName = SCOPE_PREFIX + meterName;
    -
    -           assertThat(addMetricAndPollResponse(testMeter, meterName),
    -                   equalTo(HELP_PREFIX + counterName + " " + 
getFullMetricName(meterName) + "\n" +
    --- End diff --
    
    getFullMetricName is now unused and can be removed.


---

Reply via email to