[
https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208444#comment-16208444
]
ASF GitHub Bot commented on FLINK-7853:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4842#discussion_r145259863
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/table/CorrelateTest.scala
---
@@ -93,9 +98,25 @@ class CorrelateTest extends TableTestBase {
"RecordType(INTEGER a, BIGINT b, VARCHAR(65536) c,
VARCHAR(65536) s)"),
term("joinType", "LEFT")
),
- term("select", "c", "s")
+ term("select", "c", "s"),
+ term("where", ">(s, '')")
)
util.verifyTable(result, expected)
}
+
+ /**
+ * Due to the improper translation of TableFunction left outer join
(see CALCITE-2004), the
+ * join predicates can only be empty or literal true.
+ */
+ @Test (expected = classOf[ValidationException])
--- End diff --
There is a sub-package `validation` that contains tests that verify correct
validation. Please move this test method into a new `CorrelateValidationTest`
there.
> Reject table function outer joins with predicates in Table API
> --------------------------------------------------------------
>
> Key: FLINK-7853
> URL: https://issues.apache.org/jira/browse/FLINK-7853
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Xingcan Cui
> Assignee: Xingcan Cui
> Priority: Blocker
> Fix For: 1.4.0
>
>
> Due to CALCITE-2004, the table function outer joins can not be normally
> executed. We should cover it up by rejecting join predicates temporarily,
> until the issue is fixed in Calcite.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
