[
https://issues.apache.org/jira/browse/FLINK-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208686#comment-16208686
]
ASF GitHub Bot commented on FLINK-7853:
---------------------------------------
Github user xccui commented on a diff in the pull request:
https://github.com/apache/flink/pull/4842#discussion_r145298482
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CorrelateITCase.scala
---
@@ -82,6 +82,42 @@ class CorrelateITCase(
TestBaseUtils.compareResultAsText(results.asJava, expected)
}
+ /**
+ * Due to CALCITE-2004, common join predicates are temporarily
forbidden.
+ */
+ @Test (expected = classOf[ValidationException])
+ def testLeftOuterJoinWithPredicates(): Unit = {
--- End diff --
This test should have been used as a normal test case for this join, i.e.,
we don't except it to raise an exception. I'd suggest to keep it for later use,
otherwise we may not be aware the test is incomplete in the future.
> Reject table function outer joins with predicates in Table API
> --------------------------------------------------------------
>
> Key: FLINK-7853
> URL: https://issues.apache.org/jira/browse/FLINK-7853
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Xingcan Cui
> Assignee: Xingcan Cui
> Priority: Blocker
> Fix For: 1.4.0
>
>
> Due to CALCITE-2004, the table function outer joins can not be normally
> executed. We should cover it up by rejecting join predicates temporarily,
> until the issue is fixed in Calcite.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
