[
https://issues.apache.org/jira/browse/FLINK-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589800#comment-14589800
]
ASF GitHub Bot commented on FLINK-2093:
---------------------------------------
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/818#issuecomment-112814353
Hey,
difference in not a fancy way of removing vertices, no :)
If you recall our previous conversation in #678, we decided to have
add/remove methods for small mutations (i.e. can be stored in a List) and
union/difference for large mutations (for large data in the form of Graph).
The `collect()` method is not "unsafe". It is simply not advised to be used
for large datasets. If you think about it, it needs to retrieve the data (which
might be distributed over several nodes) from to local JVM and trigger the
program execution.
If you found that the only way to implement `difference` is to overload
`removeVertices`, then we should also consider what this means in terms of the
API. If we have a remove* method for DataSets, don't we also need a
corresponding add*? You see how this goes back to #678 :)
> Add a difference method to Gelly's Graph class
> ----------------------------------------------
>
> Key: FLINK-2093
> URL: https://issues.apache.org/jira/browse/FLINK-2093
> Project: Flink
> Issue Type: New Feature
> Components: Gelly
> Affects Versions: 0.9
> Reporter: Andra Lungu
> Assignee: Shivani Ghatge
> Priority: Minor
>
> This method will compute the difference between two graphs, returning a new
> graph containing the vertices and edges that the current graph and the input
> graph don't have in common.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
