[
https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209260#comment-16209260
]
ASF GitHub Bot commented on FLINK-6444:
---------------------------------------
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4705#discussion_r145401310
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
---
@@ -439,7 +439,7 @@ public CheckpointingMode getCheckpointingMode() {
* from operations on {@link
org.apache.flink.streaming.api.datastream.KeyedStream}) is maintained
* (heap, managed memory, externally), and where state
snapshots/checkpoints are stored, both for
* the key/value state, and for checkpointed functions (implementing
the interface
- * {@link org.apache.flink.streaming.api.checkpoint.Checkpointed}).
+ * {@link
org.apache.flink.streaming.api.checkpoint.CheckpointedFunction}).
--- End diff --
Thanks @pnowojski for review. I am appreciate it! Hmm, I am not sure if it
exists maven plugins tools for checking the same thing. I will updated the code
based on your suggestions. Then, watch the test what will happen. Why did I put
it in ```manual``` package, because I found a class named
```CheckForbiddenMethodsUsage``` might did the same stuff. So, I also did it
like this. Do you have any good idea where it should put ?
> Add a check that '@VisibleForTesting' methods are only used in tests
> --------------------------------------------------------------------
>
> Key: FLINK-6444
> URL: https://issues.apache.org/jira/browse/FLINK-6444
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: Stephan Ewen
> Assignee: mingleizhang
>
> Some methods are annotated with {{@VisibleForTesting}}. These methods should
> only be called from tests.
> This is currently not enforced / checked during the build. We should add such
> a check.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
