[ 
https://issues.apache.org/jira/browse/FLINK-6444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209277#comment-16209277
 ] 

ASF GitHub Bot commented on FLINK-6444:
---------------------------------------

Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4705#discussion_r145403730
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
 ---
    @@ -439,7 +439,7 @@ public CheckpointingMode getCheckpointingMode() {
         * from operations on {@link 
org.apache.flink.streaming.api.datastream.KeyedStream}) is maintained
         * (heap, managed memory, externally), and where state 
snapshots/checkpoints are stored, both for
         * the key/value state, and for checkpointed functions (implementing 
the interface
    -    * {@link org.apache.flink.streaming.api.checkpoint.Checkpointed}).
    +    * {@link 
org.apache.flink.streaming.api.checkpoint.CheckpointedFunction}).
    --- End diff --
    
    I have changed it to ```ListCheckpointed``` class instead.


> Add a check that '@VisibleForTesting' methods are only used in tests
> --------------------------------------------------------------------
>
>                 Key: FLINK-6444
>                 URL: https://issues.apache.org/jira/browse/FLINK-6444
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>            Reporter: Stephan Ewen
>            Assignee: mingleizhang
>
> Some methods are annotated with {{@VisibleForTesting}}. These methods should 
> only be called from tests.
> This is currently not enforced / checked during the build. We should add such 
> a check.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to