Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r145978661
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -269,4 +315,49 @@ private void decodeBufferOrEvent(RemoteInputChannel
inputChannel, NettyMessage.B
bufferOrEvent.releaseBuffer();
}
}
+
+ private void writeAndFlushNextMessageIfPossible(Channel channel) {
+ if (channelError.get() != null || !channel.isWritable()) {
+ return;
+ }
+
+ while (true) {
+ RemoteInputChannel inputChannel =
inputChannelsWithCredit.poll();
+
+ // The input channel may be null because of the write
callbacks that are executed
+ // after each write, and it is also no need to notify
credit for released channel.
+ if (inputChannel == null || inputChannel.isReleased()) {
+ return;
+ }
+
+ AddCredit msg = new AddCredit(
+ inputChannel.getPartitionId(),
+ inputChannel.getAndResetCredit(),
+ inputChannel.getInputChannelId());
+
+ // Write and flush and wait until this is done before
+ // trying to continue with the next input channel.
+ channel.writeAndFlush(msg).addListener(writeListener);
+
+ return;
--- End diff --
So what is the point of having this `while (true)` if it always terminates
after first iteration?
I still think this return is a mistake. Let's say
1. `notifyCreditAvailable` is called 4 times, enqueuing 4 `InputChannel`s
and calling `writeAndFlushNextMessageIfPossible()` 4 times. However because
`channel.isWritable()` returned true, nothing was executed and
`inputChannelsWithCredit` has 4 `inputChannels`
2. channel writability changes, `writeAndFlushNextMessageIfPossible` is
called once, this loop rotates only once, only one `inputChanel` is processed,
`inputChannelsWithCredit` still has 3 elements, which are dangling indefinitely?
---
