Github user zhijiangW commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r146741962
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
@@ -64,23 +75,36 @@
@Test(timeout = 60000)
@SuppressWarnings("unchecked")
public void testReleaseInputChannelDuringDecode() throws Exception {
- // Mocks an input channel in a state as it was released during
a decode.
- final BufferProvider bufferProvider =
mock(BufferProvider.class);
- when(bufferProvider.requestBuffer()).thenReturn(null);
- when(bufferProvider.isDestroyed()).thenReturn(true);
-
when(bufferProvider.addBufferListener(any(BufferListener.class))).thenReturn(false);
-
- final RemoteInputChannel inputChannel =
mock(RemoteInputChannel.class);
- when(inputChannel.getInputChannelId()).thenReturn(new
InputChannelID());
-
when(inputChannel.getBufferProvider()).thenReturn(bufferProvider);
-
- final BufferResponse receivedBuffer = createBufferResponse(
- TestBufferFactory.createBuffer(), 0,
inputChannel.getInputChannelId(), 2);
-
- final PartitionRequestClientHandler client = new
PartitionRequestClientHandler();
- client.addInputChannel(inputChannel);
-
- client.channelRead(mock(ChannelHandlerContext.class),
receivedBuffer);
+ final NetworkBufferPool networkBufferPool = new
NetworkBufferPool(10, 32, MemoryType.HEAP);
--- End diff --
Yes, I will split the olds tests in a separate commit later. :)
---
