[ 
https://issues.apache.org/jira/browse/FLINK-6094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213922#comment-16213922
 ] 

ASF GitHub Bot commented on FLINK-6094:
---------------------------------------

Github user xccui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4471#discussion_r146104726
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/UpdatingPlanChecker.scala
 ---
    @@ -56,16 +58,20 @@ object UpdatingPlanChecker {
       }
     
       /** Identifies unique key fields in the output of a RelNode. */
    -  private class UniqueKeyExtractor extends RelVisitor {
    +  private class UniqueKeyExtractor {
    --- End diff --
    
    Are these changes on `UniqueKeyExtractor` necessary? I'd suggest to make it 
a separate issue (and for inputs retraction as well).


> Implement stream-stream proctime non-window  inner join
> -------------------------------------------------------
>
>                 Key: FLINK-6094
>                 URL: https://issues.apache.org/jira/browse/FLINK-6094
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Hequn Cheng
>
> This includes:
> 1.Implement stream-stream proctime non-window  inner join
> 2.Implement the retract process logic for join



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to